search

ccfp / github-issue-finder

GitHub issue finder
https://github-issue-finder.ccfp.now.sh
MIT License
3 stars 0 forks source link

Feat/results poc #30

Closed pete-murphy closed 5 years ago

pete-murphy commented 5 years ago

🚧 Work in progress This is very rough, just showing the raw JSON more-or-less. Haven't polished the GQL query, and the variables are hardcoded in. Not gonna merge yet, so to work on this locally:

git checkout -t master/feat/results-poc

You'll need a .env file with a REACT_APP_GH_KEY variable for hitting the GitHub API. Set that variable equal to the personal access token that you can create here: https://help.github.com/en/articles/creating-a-personal-access-token-for-the-command-line. Let me know if you have questions.

todo[bot] commented 5 years ago

Add REACT_APP_GH_KEY to Now variables

https://github.com/ccfp/github-issue-finder/blob/7f185d63fc5265f8da94aacf0d2aa09662e052a9/src/views/Results.js#L8-L13

This comment was generated by todo based on a TODO comment in 7f185d63fc5265f8da94aacf0d2aa09662e052a9 in #30. cc @ccfp.
vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://github-issue-finder-git-feat-results-poc.ccfp.now.sh

todo[bot] commented 5 years ago

Read variables from URL query string

https://github.com/ccfp/github-issue-finder/blob/7f185d63fc5265f8da94aacf0d2aa09662e052a9/src/views/Results.js#L31-L36

This comment was generated by todo based on a TODO comment in 7f185d63fc5265f8da94aacf0d2aa09662e052a9 in #30. cc @ccfp.
todo[bot] commented 5 years ago

Fix this query to get all the info that is illustrated in the mock-up

https://github.com/ccfp/github-issue-finder/blob/7f185d63fc5265f8da94aacf0d2aa09662e052a9/src/views/Results.js#L53-L58

This comment was generated by todo based on a TODO comment in 7f185d63fc5265f8da94aacf0d2aa09662e052a9 in #30. cc @ccfp.
VinceGrilli commented 5 years ago

Took longer than I care to admit but I learned all about env variables and got that working. I'm going spend some more time in a little while working on our querys and maybe get those components started. I'm really enjoying learning about GraphQL and the Apollo client

VinceGrilli commented 5 years ago

Nothing pretty yet but I fixed our variable name and started rendering our results page. Ive been following an Apollo tutorial using render props so it took a while to wrap my head around the hooks syntax but I got it. Man it was satisfying to see that data pop up when I finally got it working 😎

VinceGrilli commented 5 years ago

Also I know gotta get used to making smaller commits after I get something working like switching out that variable name. I'll watch your friends video again and try to pick up more good habbits. The way you have this Repo set up really seems like the way to do it

pete-murphy commented 5 years ago

Yeah, I'm still figuring out the git flow—I feel like as master gets more stable, maybe it makes sense to have a separate development branch for "works-in-progress" items like this branch, which we would merge feature branches into and then when they prove stable merge them to master. But that would require some additional CI setup that I'm too lazy to (learn how to) do at the moment 🙈.

In any case, I'm just gonna merge this, since we're still developing a "proof of concept" and basic features still need to be added before it makes sense to guard master.