search

cch1 / http.async.client

Async Http Client - Clojure
http://cch1.github.com/http.async.client
267 stars 40 forks source link

Implement PATCH method #42

Closed erlingmat closed 11 years ago

erlingmat commented 12 years ago

I would like to have the PATCH method implemented. So far, only clj-http implements the PATCH method that I need in my project. But it is bulky.

neotyk commented 12 years ago

Do you have some public server that supports PATCH method so I can test against it?

erlingmat commented 12 years ago

Only if you have a salesforce.com account :/ our own servers do not support PATCH.

-----Original Message----- From: Hubert Iwaniuk [mailto:notifications@github.com] Sent: Wed 9/5/2012 11:27 AM To: neotyk/http.async.client Cc: Erling Matthiesen Møller Subject: Re: [http.async.client] Implement PATCH method (#42)

Do you have some public server that supports PATCH method so I can test against it?

Reply to this email directly or view it on GitHub: https://github.com/neotyk/http.async.client/issues/42#issuecomment-8292374

neotyk commented 12 years ago

Based on assumption that PATCH is like POST/PUT I will generate version for you this evening for testing.

erlingmat commented 12 years ago

Cool. Thanks man.

Sendt fra min iPhone

Den 05/09/2012 kl. 13.09 skrev "Hubert Iwaniuk" notifications@github.com:

Based on assumption that PATCH is like POST/PUT I will generate version for you this evening for testing.

— Reply to this email directly or view it on GitHub.

neotyk commented 12 years ago

I've pushed version that has PATCH method same as PUT/POST to clojars https://clojars.org/http.async.client/versions/0.5.0-SNAPSHOT

Please let me know if it works for you.

erlingmat commented 11 years ago

I get this message when booting jetty WARNING: promise already refers to: #'clojure.core/promise in namespace: http.async.client.request, being replaced by: #'http.async.client.util/promise WARNING: promise already refers to: #'clojure.core/promise in namespace: http.async.client, being replaced by: #'http.async.client.util/promise

I did not get that message before upgrading to async client 0.5.0 snapshot.

-Erling

-----Original Message----- From: Hubert Iwaniuk [mailto:notifications@github.com] Sent: Wed 9/5/2012 6:26 PM To: neotyk/http.async.client Cc: Erling Matthiesen Møller Subject: Re: [http.async.client] Implement PATCH method (#42)

I've pushed version that has PATCH method same as PUT/POST to clojars https://clojars.org/http.async.client/versions/0.5.0-SNAPSHOT

Please let me know if it works for you.

Reply to this email directly or view it on GitHub: https://github.com/neotyk/http.async.client/issues/42#issuecomment-8304775

neotyk commented 11 years ago

Updated snapshot, please try again.

Apart from WARNING, did the PATCH method work?

erlingmat commented 11 years ago

I did not get that far, the jetty never booted due to some other things :(

-Erling

-----Original Message----- From: Hubert Iwaniuk [mailto:notifications@github.com] Sent: Mon 9/10/2012 11:12 AM To: neotyk/http.async.client Cc: Erling Matthiesen Møller Subject: Re: [http.async.client] Implement PATCH method (#42)

Updated snapshot, please try again.

Apart from WARNING, did the PATCH method work?

Reply to this email directly or view it on GitHub: https://github.com/neotyk/http.async.client/issues/42#issuecomment-8417933

neotyk commented 11 years ago

Did it work with snapshot release?

erlingmat commented 11 years ago

Yes thank you. My sunshine case worked Well.

-Erling

Sendt fra min iPhone

Den 20/09/2012 kl. 16.30 skrev "Hubert Iwaniuk" notifications@github.com:

Did it work with snapshot release?

— Reply to this email directly or view it on GitHub.

neotyk commented 11 years ago

Glad to hear that! Will bake a release soon. Do you have any urgent need to for it not to be in snapshot?

erlingmat commented 11 years ago

We would very much like to release our own software to production, but it cannot be done with snapshot releases inside. Do you have plans for a release soon?

neotyk commented 11 years ago

I was planning to update documentation first, but will cut release today without it. Will keep you posted.

erlingmat commented 11 years ago

Great thank you :)

neotyk commented 11 years ago

Release available in https://clojars.org/http.async.client