search

cch1 / http.async.client

Async Http Client - Clojure
http://cch1.github.com/http.async.client
267 stars 40 forks source link

ning dependency is outdated #54

Closed cch1 closed 8 years ago

cch1 commented 10 years ago

com.ning/async-http-client is up to version 1.7.21 and the released versino of this library depends on 1.7.10. The transitive dependency to io.netty/netty is for "3.4.4.Final" -that library would be updated to "3.6.6.Final".

We are experiencing strange TCP connection issues and hope that such an update will resolve them.

vrivellino commented 10 years ago

We're seeing issues with AsyncHttpClient-Reaper threads increasing indefinitely. I think this might be fixed in later versions of ning. Any chance we can get the dependency updated to 1.7.19 or later?

neotyk commented 10 years ago

@cch1 Thank you for reporting the issue. @vrivellino I'm working on it, unfortunately with new release there is an regression.

vrivellino commented 10 years ago

@neotyk Understood - thanks for the update.

slandelle commented 10 years ago

@neotyk Which regression are you talking about? Is this on the AHC side, or on yours?

neotyk commented 10 years ago

@slandelle There is an issue with getRawUrl when query parameters require encoding. If you can read Clojure please look at: https://github.com/neotyk/http.async.client/blob/development/test/http/async/client/test.clj#L801

Cheers, Hubert.

slandelle commented 10 years ago

@neotyk Sadly, I can't...

neotyk commented 10 years ago

@slandelle I'll create an issue in AHC if I can reproduce it with plain java. And if I can't I'll know what to fix on my side ;-)

slandelle commented 10 years ago

@neotyk Yes please.

neotyk commented 10 years ago

@slandelle I've created a test case in pure Java. Please take a look at: https://gist.github.com/neotyk/8165807

Is this a misuse of gerRawUrl?

slandelle commented 10 years ago

OK, I see. Opened an issue on AHC side to have this clarified with other committers: https://github.com/AsyncHttpClient/async-http-client/issues/447

cch1 commented 10 years ago

Progress on https://github.com/AsyncHttpClient/async-http-client/issues/588

cch1 commented 9 years ago

Now that https://github.com/AsyncHttpClient/async-http-client has been stable on version 1.9.x for a while (since last July 2014), and now that the blocking issue for this Clojure issue has been resolved, can we please get an upgrade for the ning dependency?

smnirven commented 9 years ago

@neotyk Any thoughts on this? Would be great to get the ning dependency upgraded. Don't want to see this die on the vine.

cch1 commented 9 years ago

For anyone who is follwing this issue, here is the current status: I have a branch on my fork that updates Clojure to 1.6 and AHC to 1.8.16. There is one failing test dealing with the http.async.client/raw-url function backed by the AHC getRawUrl method. I don't see a way to resolve this bug without updating AHC to at least version 1.9.x -and that will take a bit longer. I hope to soon release an 0.5.3-SNAPSHOT version with this failing test so that we can get some eyes on the other changes required to update this library.

cch1 commented 9 years ago

Another status update: Version 0.6.0 of http.async.client updates the ning depdency to 1.8.16 -the latest 1.8.X version. It is almost completely backwards compatible with the 0.5.3 version of http.async.client with the minor exception of the deprecated raw-url function which has now been removed.

cch1 commented 8 years ago

This issue is finally resolved and the ning AHC dependency is completely up-to-date. Thanks @pbostrom !