search

cch1 / http.async.client

Async Http Client - Clojure
http://cch1.github.com/http.async.client
267 stars 40 forks source link

Websockets in v1.0.0 are broken: websocket calls upgrade-handler with list instead of unrolled args #66

Closed timmc closed 8 years ago

timmc commented 8 years ago

Your README advertises v1.0.0 as the latest release (based on Clojars), but it doesn't work.

In https://github.com/cch1/http.async.client/blob/v1.0.0/src/clj/http/async/client.clj#L311 websocket has a list of options e.g. (:open fn :close fn) and calls upgrade-handler, which is expecting unrolled args: https://github.com/cch1/http.async.client/blob/v1.0.0/src/clj/http/async/client/websocket.clj#L101

pbostrom commented 8 years ago

Sorry, the websocket client still needs some work. I should have this fixed soon

pbostrom commented 8 years ago

Fixed with 94e73e4, v1.0.1 is deployed on Clojars. Thanks for testing this out.

timmc commented 8 years ago

Ah, thanks!