search

cch1 / http.async.client

Async Http Client - Clojure
http://cch1.github.com/http.async.client
267 stars 40 forks source link

fix bad map :or destructuring - default not being applied #76

Closed puredanger closed 7 years ago

puredanger commented 7 years ago

In the :or map, the keys are the let-bound symbols, not the keys being looked up in the map.

cch1 commented 7 years ago

That's a bit embarrassing...

puredanger commented 7 years ago

It happens. :) In 1.9 it will actually fail to compile due to spec checking so I'm try find ones out in the wild early.

cch1 commented 7 years ago

That’s great to hear -I’m looking forward to using spec at Room Key (day job).

-Chris

On 25 Jul, 2016, at 18:25, Alex Miller notifications@github.com wrote:

It happens. :) In 1.9 it will actually fail to compile due to spec checking so I'm try find ones out in the wild early.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/cch1/http.async.client/pull/76#issuecomment-235105198, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAc-NRa0YIX_s4E7tKE-hDvOuOuyaxyks5qZTfngaJpZM4JUi4C.