search

cch1 / http.async.client

Async Http Client - Clojure
http://cch1.github.com/http.async.client
267 stars 40 forks source link

Add protocol option to ssl-context #85

Open leek5pin opened 4 years ago

leek5pin commented 4 years ago

When setting up the ssl-context I need to use TLSv1.2 or my request will fail. That is an optional parameter in the setup through the java api, but is not in your http async client. As result, on creation of the ssl-context it defaults to TLS. The proposed change would add an optional :protocol key to the ssl-context function which would default to TLS when not present, but could be specified.

cch1 commented 4 years ago

@sean-stockholm Any chance you can add a test?

leek5pin commented 4 years ago

I've been swamped with moving. I'll find some time to make a test before EOD Monday.

cch1 commented 1 year ago

I've been swamped with moving. I'll find some time to make a test before EOD Monday.

Which Monday? :)

I'm in a good place to merge this PR if you can get a test in place.