search

cch1 / http.async.client

Async Http Client - Clojure
http://cch1.github.com/http.async.client
267 stars 40 forks source link

[Fix #90] Allow for listening to both text and byte messages #91

Closed slipset closed 1 year ago

slipset commented 2 years ago

We have a use case at work where we listen to both text and byte messages. This pre disallows that. I'm not sure if there is a reason for disallowing, so please close if this is not a good idea.

Looking back into the old issue that introduced this assertion, the underlying problem might now just be fixed because now there is only one listener created, and thus close should only be called once?

cch1 commented 1 year ago

I'm sorry it's taken me so long to merge this PR! I will probably remove the test that you modified -it's not really asserting anything meaningful anymore.

slipset commented 1 year ago

No worries, thanks for moving it forward!