search

cch5ng / frontend-nanodegree-arcade-game

Arcade game written in JavaScript, using HTML Canvas
http://cch5ng.github.io/frontend-nanodegree-arcade-game/
0 stars 0 forks source link

refactor collision logic #1

Closed cch5ng closed 9 years ago

cch5ng commented 9 years ago

move collision check logic out into separate function (i.e. checkCollision). impacts app.js and engine.js. current collision check is in the player.update() function.

cch5ng commented 9 years ago

fixed on v2 branch. pending first udacity review before merge with master. https://github.com/cch5ng/frontend-nanodegree-arcade-game/commit/ad384edde22f42e0e4883b789d9dfc1abab8b7dd#diff-b5e8da924c740c5bbb12e4ad0dd9b921

cch5ng commented 9 years ago

checked changes into master.