cch5ng / frontend-nanodegree-arcade-game

Arcade game written in JavaScript, using HTML Canvas
http://cch5ng.github.io/frontend-nanodegree-arcade-game/
0 stars 0 forks source link

add option to choose different player before game play starts #5

Closed cch5ng closed 9 years ago

cch5ng commented 9 years ago
cch5ng commented 9 years ago

need to refactor b/c some of the canvas click logic is already defined in the app. but not exactly sure how much interaction should be defined in engine vs app.

cch5ng commented 9 years ago

in v4, made changes mainly to app.js (new Avatar object). and minor updates to engine.js. but wonder if it could have been done better, like using css borders rather than creating additional graphics. is it better to do DOM manipulation thru js for the pre-game start screen or to be consistent and use the canvas. probably push to master and gh-pages but these changes will not be reflected then in geolocation branch

cch5ng commented 9 years ago

made the merges to gh-pages and master. closing for now.