cchallu / n-hits

170 stars 25 forks source link

About training procedures and doc #3

Closed Guan-t7 closed 2 years ago

Guan-t7 commented 2 years ago

Update: Additional questions

I hope these could help improve your model (Of course the metric presented is already impressive enough :).

=============================================== Thank you for this amazing work. I found these typo and doc issues:

https://github.com/cchallu/n-hits/blob/4e929ed31e1d3ff5169b4aa0d3762a0040abb8db/src/models/nhits/nhits.py#L398-L405

  1. while documented as a multiplier, n_time_in is actually the final Lookback period

https://github.com/cchallu/n-hits/blob/4e929ed31e1d3ff5169b4aa0d3762a0040abb8db/src/models/nhits/nhits.py#L248-L250

  1. n_layers in nhits_multivariate.py should be [ 3*[2] ] rather than 9 since elements are indexed across 3 stacks

  2. loss_hypar should be an int like 7 or 24 from its context

  3. There are bypassed logics for exogenous variables in nhits model. I wonder if they can be put into work now?

cchallu commented 2 years ago

Hi @Guan-t7, thanks for the interest in our paper! Regarding your comments:

  1. We follow the NBEATS' training strategy, which samples random windows at each time and doesn't necessarily cover all the training set. We have used this strategy extensively, and covering all the training set doesn't improve performance in most cases.

  2. Traffic has more than 800 time series, are you sending the history of all the time series? If so, the input vector is larger than 70k, a feed-forward network is not the best architecture to learn interactions between a large number of inputs.

  3. Yes, we realized there was a mistake with the scheduling, in particular with the datasets with more time series such as ECL and Traffic. We plan to fix this soon.

  4. Yes, 1000 iterations is conservative for a dataset as Traffic. However, we wanted to keep the search space constant between the 6 datasets of the paper. The performance can be further improved by exploring different hyperparameters for each dataset separately.

Guan-t7 commented 2 years ago

Cool. Thanks for your reply!