Fix method generation in WrappedDistinguishedName.

cchandler / certificate_authority

Ruby gem for managing the core functions outlined in RFC-3280 for PKI

https://github.com/cchandler/certificate_authority

194 stars 44 forks source link

Fix method generation in WrappedDistinguishedName. #37

Closed dennissivia closed 5 years ago

dennissivia commented 10 years ago

Without this patch the initializer used downcase to cast the x509 subject entry into a method. This led to emailAddress being converted to emailaddress, but the classes method is called email_address. This patch introduces a underscore method that can convert camal-cased entries from x509 subects into underscore instance methods. Also added tests for email_address access to DistinguishedName unit tests

cchandler commented 10 years ago

Seems reasonable to me.

dennissivia commented 10 years ago

is there anything to do before the pull request will be merged?

cchandler commented 9 years ago

I've got a few free hours so I'm going back through my email. If you can fix the merge conflict I'll merge this in today.