Cleanup gemspec, rakefile and upgrade dependencies

cchandler / certificate_authority

Ruby gem for managing the core functions outlined in RFC-3280 for PKI

https://github.com/cchandler/certificate_authority

194 stars 44 forks source link

Cleanup gemspec, rakefile and upgrade dependencies #56

Closed knapo closed 4 years ago

knapo commented 4 years ago

The main reason I creating this PR is that our fossa scanner complains that redgreen gem (which is a dev dependence of jewler gem) doesn't have a licence specified. Since both redgreen and jewler are not longer being maintained, certificate_authority is the gem which requires some care :)

What this PR does is:

Change travis config to test against recent ruby versions
Stop using jewler, which is not longer maintained (gem can be simply released with rake build + rake release)
Upgrade and cleanup gemspec to follow most recent style
Cleanup Rakefile
Fix constant ::Fixnum is deprecated warning
Add .rspec file and remove individual helper requires.

Once the PR is merged, I think it's time to release 1.0.0 :)

coveralls commented 4 years ago

Coverage increased (+4.0%) to 98.717% when pulling fbf46f6afaeab764807ffab95bd626e0b3854853 on knapo:cleanup-and-upgrades into 916558bca807b7bce209d84a9bd31f122dfdf3dc on cchandler:master.

knapo commented 4 years ago

@cchandler Hope, you'll find a while to review and merge this PR. Thanks!

cchandler commented 4 years ago

Hey, thanks for looking into this! Most of it is long overdue 😅. I'll see if I can find some time this week to merge it in.

knapo commented 4 years ago

@cchandler just a friendly reminder :)

cchandler commented 4 years ago

Things are kinda returning to normal for me. Taking a look this afternoon.

knapo commented 4 years ago

Many thanks! If you can release a new version with the changes, it would be awesome!

On Thu, 28 May 2020, 22:12 Chris Chandler, notifications@github.com wrote:

Merged #56 https://github.com/cchandler/certificate_authority/pull/56 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cchandler/certificate_authority/pull/56#event-3384454155, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPTCDUXR4D6MAGCLQWDFTRT3ARLANCNFSM4LFP2I5A .

cchandler commented 4 years ago

Thank you so much for the time and contribution! I've bumped the version to 1.0.0 (on master) and pushed to rubygems. The last time I published this gem was apparently 2012 🤣