cchang5 / quantum_linear_programming

1 stars 9 forks source link

Draft feedback 08/28 #28

Closed ckoerber closed 4 years ago

ckoerber commented 4 years ago

This issue addresses questions and adds comments regarding the ILP draft send out by @cchang5 08/28.

I tried to infer questions potential readers might have. Obviously, this is subjective, so feel free to point out if some thoughts are not helpful.

Btw. I am not sure how much this helps, but I did some refactoring a few months ago summarized in PR #11

General remarks

Specific

cchang5 commented 4 years ago

I quickly skimmed the comments and I agree with most of your comments and concerns. Especially with the reordering of the sections though, we should talk about it more. I wrote it this way because it was how it is ordered in my head, and I wanted to push out a first draft asap. I also want to send this to either Sci Rep or Nature QIS, so they have guidelines on how the paper should be structured as well (at least Nat. QIS does). So I can explain to you a bit how this paper is put together with respect to that as well.

In any case, let's find a time to chat about this for sure.

cchang5 commented 4 years ago

Done