Closed ng185115 closed 8 months ago
Hi @cchanxzy
Can you please review this PR and if possible, could you consider merging this PR at your earliest convenience?
In this PR I have fixed it only for decimal numbers , if you want this to be applicable for other decimal separators as well I can modify this condition to
if (decimalSeparator && decimalSeparator !== '-' && value.startsWith(decimalSeparator)) { value = '0' + value; }
I'm excluding this ' - ' decimal separator as we doesn't know if that first character is intended to be the separator or negative sign.
Thanks for your PR @ng185115!
In this PR I have fixed it only for decimal numbers , if you want this to be applicable for other decimal separators as well I can modify this condition to
if (decimalSeparator && decimalSeparator !== '-' && value.startsWith(decimalSeparator)) { value = '0' + value; }
I'm excluding this ' - ' decimal separator as we doesn't know if that first character is intended to be the separator or negative sign.
Yes I think that's a good suggestion, if you update the PR with your suggestion I'll be happy to merge it.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
026329f
) 100.00% compared to head (9907e29
) 100.00%. Report is 1 commits behind head on main.:exclamation: Current head 9907e29 differs from pull request most recent head 3c10ed1. Consider uploading reports for the commit 3c10ed1 to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @cchanxzy Made changes to support all decimal separators , Can you please review and merge it as soon as possible?
Merged. Thanks @ng185115 !
Thanks @cchanxzy !! When can we expect this to be published ?
:tada: This PR is included in version 3.7.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Ah just realised that the commit message didn't follow the semantic release convention, so it didn't trigger a release. That's on me, I should have checked.
I've just made a commit to trigger the release, so this commit will be included.
Thanks @cchanxzy !
Issue https://github.com/cchanxzy/react-currency-input-field/issues/299
Built and tested.