search

cchdo / hydro

The big ol CCHDO netCDF-CF project
https://hydro.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

`bottle_time` needs explicit fill value #18

Closed DocOtak closed 2 years ago

DocOtak commented 3 years ago

Unlike the time auxiliary coordinate, the bottle_time is allowed to have no value. Currently the bottle_time var does not have a _FillValue attribute set, which it should be since values are allowed to be empty.

This will only be an attribute change and not change the underlying data array at all since NaNs are already being used. In commonly used programs for reading netcdf (xarray, matlab etc..), when a numeric variable has a fill value set, the internal (to python or matlab) dtype is set to something "floaty" and mapped to NaNs. All we will do with this attribute is indicate that having no value is allowed for this variable.

This problem is also a good place to start on the "version migration" machinery.

DocOtak commented 2 years ago

This was fixed in 7bcc9c75b4f75793e4ce900c9d514c98c762bf4a