cchdo / hydro

The big ol CCHDO netCDF-CF project
https://hydro.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Implement Add/Remove parameter for core ops #38

Closed DocOtak closed 3 months ago

DocOtak commented 3 months ago

This is a tracking PR while the work is done. This will start with adding tests for behavior before working on implementation. As of this first commit, the added test will fail since the implementation doesn't work yet

Here are some cases that need consideration:

DocOtak commented 3 months ago

This should have all the machinery needed to fix the S04P CTD file by remerging the BEAMCP submission back into the data. I'm going to attempt this before merging this pull request.

The function itself also needs some additional documentation and usage notes. Adding provenance attrs might also be worth exploring, but shouldn't hold up getting the data fixed.

DocOtak commented 3 months ago

The basic functionality is ready I think, the edge cases noted in the original PR text can be addressed when they come up as blockers or some other later time.