cchdo / libcchdo

Other
0 stars 1 forks source link

`hydro check any` refactoring needed #41

Open DocOtak opened 11 years ago

DocOtak commented 11 years ago

Original report by abarna (Bitbucket: abarna, GitHub: abarna).


Currently, the check any functionality is locked inside the scripts folder inside a method. These should probably be take out of scripts.py and made able to be called on any datafile (path or object?) and generally accessible outside the hydro command.

Additionally, they should be encapsulated in such a way that they might be passed to the do_for_cruise_directories method so every file in the data directory can be checked for integrity.

Some thought/work should also go into what the output should be. Perhaps having an output that is able to be redirected to a file for later browsing...

DocOtak commented 11 years ago

Original comment by myshen (Bitbucket: myshen, GitHub: myshen).


Specifically, the actual checks performed are defined as a functions inside a function. These should be pulled up and out of the scripts module.