cchdo / libcchdo

Other
0 stars 1 forks source link

BTL_DATE and BTL_TIME are formatted with 4 decimal places #52

Closed DocOtak closed 11 years ago

DocOtak commented 11 years ago

Original report by Carolina Berys-Gonzalez (Bitbucket: cberysgo, ).


date looks like 20130405.0000

DocOtak commented 11 years ago

Original comment by myshen (Bitbucket: myshen, GitHub: myshen).


Thanks for the report. Please provide a sample file? (Edit -> Attach)

DocOtak commented 11 years ago

Original comment by Carolina Berys-Gonzalez (Bitbucket: cberysgo, ).


Hm.. can't reproduce this one now. Sorry :/ Resolved??

DocOtak commented 11 years ago

Original comment by myshen (Bitbucket: myshen, GitHub: myshen).


Was it on a specific computer?

DocOtak commented 11 years ago

Original comment by Carolina Berys-Gonzalez (Bitbucket: cberysgo, ).


It was on ghdc, but I was unable to reproduce even in the same environment in the exact same directory. I ran into some other slip ups because units were wrong and hydro didn't like it... so maybe this was related to that? Sorry I don't know more, but when I did the conversion this time around the BTL_DATE and BTL_TIME were just fine.

DocOtak commented 11 years ago

Original comment by myshen (Bitbucket: myshen, GitHub: myshen).


ghdc was updated in the mean time. Maybe if you send me the files I can replicate it with a different commit? I'd like to write a test case for it.

DocOtak commented 11 years ago

Original comment by Carolina Berys-Gonzalez (Bitbucket: cberysgo, ).


Got it

DocOtak commented 11 years ago

Original comment by Carolina Berys-Gonzalez (Bitbucket: cberysgo, ).


This one should be just like my original except I had both legs. I have since edited the crap out of all the files so I don't have the exact one which created the original issue, sorry. I ran hydro convert any type -t btl.ex input output

DocOtak commented 11 years ago

Original comment by myshen (Bitbucket: myshen, GitHub: myshen).


Bug is present up to d0b12f6. Commit 0e34600 follows which retains data's decimal places resolves this issue. Writing test now. Thanks for the report.