search

cchdo / libcchdo

Other
0 stars 1 forks source link

MERGE - /MILLE converted to O/OO #55

Closed DocOtak closed 11 years ago

DocOtak commented 11 years ago

Original report by Carolina Berys-Gonzalez (Bitbucket: cberysgo, ).

On ghdc

Ran a merge and got some conversion notes 0/00 changed to O/OO, but should be /MILLE. Might be something in the difference between "units" and "unit_mnemonic"

hydro merge botex_and_botex --output merged_hy1.csv --on STNNBR,CASTNO,SAMPNO,BTLNBR orig_hy1.csv c14-13_hy1.csv DELC14 DELC14_FLAG_W C14ERR DELC13 DELC13_FLAG_W

Messages:

1932:54,370 I merge.py:233 filter_params_to_merge Merging ['DELC14', 'DELC14_FLAG_W', 'C14ERR', 'DELC13', 'DELC13_FLAG_W'] 1932:54,371 W merge.py:424 merge_datafiles Changed units for DELC14 from u'0/00' to 'O/OO' 1932:54,373 W merge.py:424 merge_datafiles Changed units for C14ERR from 'O/OO' to 'O/OO' 1932:54,374 W merge.py:424 merge_datafiles Changed units for DELC13 from u'0/00' to 'O/OO' 1932:54,482 W model/datafile.py:214 check_and_replace_parameter Mismatched units for 'C14ERR'. Found 'O/OO' but expected '/MILLE' 1932:54,482 I model/datafile.py:223 check_and_replace_parameter No unit converter registered with file for 'O/OO' -> '/MILLE'. Skipping conversion.

DocOtak commented 11 years ago

Original comment by myshen (Bitbucket: myshen, GitHub: myshen).

Please check that derivative file also has /MILLE. If asked to merge a column merge algo will overwrite units.

DocOtak commented 11 years ago

Original comment by Carolina Berys-Gonzalez (Bitbucket: cberysgo, ).

Thats it, thanks

DocOtak commented 11 years ago

Original comment by Carolina Berys-Gonzalez (Bitbucket: cberysgo, ).

could the message be more explicit? I guess I know now, but didn't get it right away. Ithought hydro always used preffered units when they are available. If O/OO was an alias for /MILLE, would it use /MILLE?

DocOtak commented 11 years ago

Original comment by myshen (Bitbucket: myshen, GitHub: myshen).

You're performing a merge operation so all hydro should do is accept the derivative as accurate and replace the units in the original. In fact if you specify a whole different unit it would happily replace it. "Convert" is misleading, it should say "replaced with"