search

cci-MaLab / Calcium-Transient-Analysis

GNU General Public License v3.0
0 stars 0 forks source link

Deal with memory leaks. #1

Closed GrowlingM1ke closed 8 months ago

GrowlingM1ke commented 1 year ago

Currently the deletion aspect of the GUI is most likely causing memory leaks as far as I understand it setParent(None) just deletes the python wrapper but not necessarily the underlying C++ structure. deleteLater() is supposed to do that but I had some trouble with executing it for the Viewer Class. It would be good if this was addressed to avoid memory leaks.

GrowlingM1ke commented 8 months ago

I'm not sure at what point exactly I had this fixed but I can confirm that within main_widgets.py the Aspect Ratio widget is set as the parent of the Viewer Class and it is set to deleteLater() for removal. Online (https://stackoverflow.com/questions/73258934/python-pyqt6-deletelater-and-child-widgets#:~:text=C%2B%2B%20object%20destruction,...%5Dchildren).) it looks like all children objects should be deleted as well so I don't think there should be any more memory leaks and I'm closing the issue.