search

ccin2p3 / puppet-patterndb

Puppet module for handling syslog-ng patterndb
Other
0 stars 3 forks source link

Manage patterndb version in generated XML files #33

Closed faxm0dem closed 1 year ago

faxm0dem commented 1 year ago

Manage patterndb version in file.

The logic is to use v6 if syslog-ng-version >= 4 and v4 elsewhere.

smortex commented 1 year ago

Okay, CI failures are caused by the fact syslog_ng_version not being known. It looks like we add module-needed facts from spec/default_module_facts.yml in:

https://github.com/ccin2p3/puppet-patterndb/blob/537c8d92d3dabf7b3bd4e8afbbb58101727187cb/spec/spec_helper.rb#L17

Creating it with some value should fix that issue, e.g.:

---
syslog_ng_version: "3.38.1"
smortex commented 1 year ago

I adjusted the PR title and labelled it so that GitHub Changelog Generator can generate a nice changelog entry that points to this PR.