search

ccin2p3 / puppet-patterndb

Puppet module for handling syslog-ng patterndb
Other
0 stars 3 forks source link

Fix/relax types #45

Open faxm0dem opened 1 year ago

faxm0dem commented 1 year ago

We just converted our 632 patterns to the new v5 format. We ran into a few incompatible changes, and this PR allows all our patterns to work out.

Basically we relax a few type constraints, which are a bit too tight compared to what's allowed in patterndb

faxm0dem commented 1 year ago

Something very annoying also, is that value must be a String. This is awkward:

test_values:
  i_am_a_number: '123'
  type: integer

This feels more right:

test_values:
  i_am_a_number: 123
  type: integer

Should we do Variant[String,Numeric] ?

smortex commented 1 year ago

Should we do Variant[String,Numeric] ?

We can.

In this case we can probably also add Float to that list and assume the end-users will only pass literals and not compute the values (0.02 vs 0.1 * 0.2)?