search

ccjr / alpaca-trade-api

MIT License
32 stars 28 forks source link

Trying to add last trade functionality #10

Closed nathanworden closed 4 years ago

nathanworden commented 4 years ago

I am new to contributing to open source, so apologies if I didn't create this correctly.

I am trying to add the ability to pull the last trade data for a stock. I added a new file named last_trade.rb and tried to copy the structure of other files in lib/alpaca/trade/api. But I don't think I did it right. I would love to be pointed in the right direction.

Thanks so much for making this!

ccjr commented 4 years ago

You forgot to add a method to Client in order to actually make the call to the API. I did implement that method in https://github.com/ccjr/alpaca-trade-api/commit/32975f8cfe5a6c03e2bf052578cbdbbd8d6d04dd, take a look, and let me know if you have any questions. I released a new version: https://rubygems.org/gems/alpaca-trade-api/versions/0.5.0