Prefixes containing spaces are listed incorrectly in Zenity

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Create a prefix containing a space in its path
2. run winetricks

What is the expected output? What do you see instead?
Instead of seeing this:
Select the default wineprefix
Select silent hill homecoming v - homecoming (Silent Hill V: Homecoming)

I see:
Select the default wineprefix
hill
homecoming

Fix:

Change line 1671 from:
printf %s " FALSE prefix=$p 'Select $_W_msg_name' "

to:
printf %s " FALSE prefix="$p" 'Select $_W_msg_name' "

Original issue reported on code.google.com by cybolic on 23 Mar 2011 at 1:03

[GoogleCodeExporter]

It's worse than that.  
winetricks makes lots of assumptions about prefix codes not containing spaces.

Can we disallow them?  I thought that's what wrapper.cfg's name property was 
for.

Original comment by daniel.r...@gmail.com on 23 Mar 2011 at 1:27

[GoogleCodeExporter]

Does this patch work for you?

Original comment by daniel.r...@gmail.com on 23 Mar 2011 at 1:37

Attachments:

• spaces.patch

[GoogleCodeExporter]

It works with that patch plus the following.

wrapper.cfg's name property was more to ensure that names don't conflict with 
filesystem limitations.
We could disallow spaces in prefixes, but they make the directory names a bit 
friendlier for the end user.

Original comment by cybolic on 23 Mar 2011 at 2:07

Attachments:

• spaces-2.patch

[GoogleCodeExporter]

Committed as of r354.

Original comment by daniel.r...@gmail.com on 24 Mar 2011 at 3:05

• Changed state: Fixed