winetricks should use W_PREFIXES_ROOT across the board (patch supplied)

[GoogleCodeExporter]

I install wine applications in a different partition (/usr/drives/wine) and 
wanted winetricks to use my prefix.
Looking at the code, wineprefix either uses W_PREFIXES_ROOT or manually uses 
$HOME/.local/share/wineprefixes.
This patches makes sure W_PREFIXES_ROOT is used everywhere.

- Gilboa

Original issue reported on code.google.com by gilb...@gmail.com on 31 Jan 2012 at 5:24

Attachments:

• winetricks-use-user-prefix.patch

[GoogleCodeExporter]

I think the patch is wrong - it should use $WINEPREFIX instead of 
$W_PREFIXES_ROOT/$verb.  But thanks for pointing this out, I'm testing and 
committing fixes.

Original comment by daniel.r...@gmail.com on 4 Apr 2012 at 9:47

[GoogleCodeExporter]

This issue was closed by revision r805.

Original comment by daniel.r...@gmail.com on 4 Apr 2012 at 9:48

• Changed state: Fixed

[GoogleCodeExporter]

For some reason winetricks doesn't always honor WINEPREFIX (which internally 
being used to initialize W_PREFIXES_ROOT) but uses 
$HOME/.local/share/wineprefixe instead.
E.g.
Line 1018:
myexec="Exec=env WINEPREFIX=\"$HOME/.local/share/wineprefixes/$W_PACKAGE\" ...
Line 7583:
myexec="Exec=env WINEPREFIX=\"$HOME/.local/share/wineprefixes/firefox\" ...
Line 7615:
myexec="Exec=env WINEPREFIX=\"$HOME/.local/share/wineprefixes/firefox\"

In all these cases, the exported WINEPREFIX should have used W_PREFIXES_ROOT 
and not .local/share/wineprefixes/XXXX.

- Gilboa

Original comment by gilb...@gmail.com on 5 Apr 2012 at 6:54

[GoogleCodeExporter]

Those lines are no longer present in winetricks.  Please check tip, 
http://winetricks.googlecode.com/svn/trunk/src/winetricks

Original comment by daniel.r...@gmail.com on 5 Apr 2012 at 3:07

[GoogleCodeExporter]

Oh, OK, thanks.

- Gilboa

Original comment by gilb...@gmail.com on 9 Apr 2012 at 4:12