search

cckec / winetricks

Automatically exported from code.google.com/p/winetricks
0 stars 0 forks source link

r798: possible bashism using kill -SIGNALNAME command #193

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
checkbashisms[*] command reports following:

  possible winetricks line 16411 kill -[0-9] or -[A-Z]):
    kill -HUP $_job   # just in case

Please use plain NUMBER, not symbolic name.

[*] Can be found in *.tar.gz at
http://packages.debian.org/unstable/devscripts

Original issue reported on code.google.com by jari.aalto.fi@gmail.com on 4 Apr 2012 at 1:30

GoogleCodeExporter commented 8 years ago 
The number isn't portable across other platforms.

Checkbashisms doesn't complain about this for me in 2.13.2. The proper fix is:
kill -s HUP $_job

http://code.google.com/p/winetricks/source/detail?r=963

Original comment by austinenglish@gmail.com on 15 Jun 2013 at 7:08