search

cckec / winetricks

Automatically exported from code.google.com/p/winetricks
0 stars 0 forks source link

Misc text fixes #22

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Here are some miscellaneous fixes to comments and user messages in winetricks 
(capitalization fixes, etc.)

Original issue reported on code.google.com by ryandesi...@gmail.com on 9 Apr 2011 at 3:41

Attachments:

GoogleCodeExporter commented 8 years ago 
I'm unlikely to apply a patch that fixes capitalization in comments, 
and I'm very unlikely to apply a patch that fixes multiple different problems.

Maybe send a patch that just fixes the one kind of user-visible typo
that bothers you most.  (The spelling of macosx, perhaps.)

Original comment by daniel.r...@gmail.com on 9 Apr 2011 at 4:00

GoogleCodeExporter commented 8 years ago 
Ryan did a great job to improve the English in the program, like in comments:

  posix => POSIX
  ubuntu => Ubuntu

The response is troubling; as if native english peaking person's time and his 
help is not wanted. The patch aims to single problem: "English grammar", so I 
don't see where there would be "fixing different problems" accusation.

Please apply, as this improves quality.

Original comment by jari.aalto.fi@gmail.com on 13 Apr 2011 at 9:34

GoogleCodeExporter commented 8 years ago 
Capitialization is not grammar, it's orthography, and not a very important form 
of it.
I am unlikely to accept patches that fix capitalization in comments,
especially changes of the form 'Posix -> POSIX'.  I mean, really, who cares?

True typos that annoy users, e.g. macosx -> Mac OS X (if that is one),
are another matter, I would gladly accept patches for those.

Also, his patch mixed several kinds of fixes together.  (It even had -misc
in the name.)
If there's a particular problem, please submit a patch that fixes just that.

Original comment by daniel.r...@gmail.com on 13 Apr 2011 at 1:18

GoogleCodeExporter commented 8 years ago 
Closing invalid because the bug report was for a set of miscellaneous
micro-issues rather than a single real problem.

Original comment by daniel.r...@gmail.com on 13 Apr 2011 at 1:19

GoogleCodeExporter commented 8 years ago 
"'Posix -> POSIX'.  I mean, really, who cares?"

"Closing invalid because the bug report was for a set of miscellaneous
micro-issues rather than a single real problem."

You just trashed Ryan's hours work. Someone, who was trying to be helpful. 
Applying the patch would have not had any ill effects, only benefits.

Original comment by jari.aalto.fi@gmail.com on 14 Apr 2011 at 8:39

GoogleCodeExporter commented 8 years ago 
If there's a user-visible spelling or grammar problem, I'd be happy
to accept individual patches for each kind of typo.  

But capitalization fixes in comments are not generally useful or helpful,
especially ones like Posix -> POSIX.  For some reason, I just don't like the
all-caps version.  (And I'm not alone; in a google search for "posix 
capitalization",
the first hit I saw spelled it Posix.)

Reasonable people can disagree on this.  I know it sucks to be told that
something that bugs you is not a bug, but not everybody can agree all the time.

Now, if y'all could add some useful functionality to the script, that 
would be a better use of our time.

Original comment by daniel.r...@gmail.com on 14 Apr 2011 at 2:12