search

cckec / winetricks

Automatically exported from code.google.com/p/winetricks
0 stars 0 forks source link

Copyright owner listing is incomplete #26

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
C.f. http://code.google.com/p/winetricks/issues/detail?id=2

In the SVN there is still this issue present (as reported in bug 2):

*) Line "Copyright (C) 2007-2011 Dan Kegel <dank@kegel.com> et al"

All Copyright holders should be listed in the code, See FSF guidelines 
http://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html which reads:

  "...But if contributors are not all assigning their copyrights to a single copyright holder, it can easily happen that one file has several copyright holders. Each contributor of nontrivial text is a copyright holder."

In winetricks' case all contributors to the code should be listed (and "et all" 
removed):

# Copyright
#   Copyright (C) 2007-2011 Dan Kegel <dank@kegel.com>
#   Copyright (C) YYYY Name <another.contributor@exampel.com>
#   Copyright (C) YYYY Name <more.contributors@exampel.com>
#   ...

*) Paragraph breaks are missing from "License" part. See 
http://www.gnu.org/copyleft/gpl-howto.html how the text should look like.

FSF: "For a one-file program, the statement (for the GPL) should look like 
this:"

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.

Original issue reported on code.google.com by jari.aalto.fi@gmail.com on 13 Apr 2011 at 9:24

GoogleCodeExporter commented 8 years ago 
Correction; As winetricks is LGPL 2, the license text near the beginning of 
file should appear like this:

    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Library General Public
    License as published by the Free Software Foundation; either
    version 2 of the License, or (at your option) any later version.

    This library is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
    Library General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.

Original comment by jari.aalto.fi@gmail.com on 13 Apr 2011 at 9:46

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r465.

Original comment by daniel.r...@gmail.com on 13 Apr 2011 at 1:44

GoogleCodeExporter commented 8 years ago 
Thanks for calling me out on the incomplete copyright holder list,
that's important.  I'll try to keep it complete.

Please file one bug report per issue.  Also please don't file whitespace bug
reports unless they truly impact readability.  I think Stallman will forgive
me the two missing linefeeds; if he says otherwise, I can add them.

Original comment by daniel.r...@gmail.com on 13 Apr 2011 at 1:46

GoogleCodeExporter commented 8 years ago 
Those are called "paragraph breaks"; and used in writing to groups different 
things in different portions. It:

a) improves legibility
b) some automated tools that examine Licenses of programs may expect the 3 
paragraphs to be found (See "copyright-update"; see "licensecheck").
c) I don't see a compelling or valid reasons to deviate from the standard FSF 
recommendation. This way Open Source keeps in line and in good quality. Entropy 
is not desirable. Compare what would happen if everyone invented their own 
modified things; Somebody called the Help option other than -h, --help etc. 
Same thing.

Original comment by jari.aalto.fi@gmail.com on 14 Apr 2011 at 8:32

GoogleCodeExporter commented 8 years ago 
I believe I learned about paragraph breaks in kindergarten.  Heck, some of my
best friends are paragraph breaks.

licensecheck has no trouble with winetricks.
copyright-update doesn't complain, either.
And I don't think any reasonable human would have trouble
with the way I format the comments in winetricks.
I use standard gnu options (-h, --help, etc.) 

In short, the main source of entropy in this discussion is... you.
Please stop worrying about whitespace.  

If you know of any problem that has a real effect on anything, I'd be glad to 
hear it.

Original comment by daniel.r...@gmail.com on 14 Apr 2011 at 2:17