search

cckec / winetricks

Automatically exported from code.google.com/p/winetricks
0 stars 0 forks source link

patch: version bump for VLC player and suggestion of PKGVERSION variable #39

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. browse http://www.videolan.org/
2. site says version 1.1.9 fixes security bugs but winetricks installs 1.1.5
3. to update verb the usual way, version number should be changed in four places

Here is a small patch. VLC player has the same problems for me as before the 
update. :-)

If PKGVERSION is not wanted, version could be taken out of title for easier
updating, since winetricks only offers one version of VLC player at a time.

Style guide says to wrap lines at 80 characters, so I put SHA1 on continuation
line.

Original issue reported on code.google.com by vl...@safetymail.info on 19 Apr 2011 at 10:34

Attachments:

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r505.

Original comment by daniel.r...@gmail.com on 23 Apr 2011 at 5:09

GoogleCodeExporter commented 8 years ago 
Did the same thing by using the $file1 variable.
The winetricks spec doesn't allow referring to
metadata variables from inside other metadata variables.

(I sometimes like having the version in the title regardless,
since that helps alert users see there's a new version.)

Original comment by daniel.r...@gmail.com on 23 Apr 2011 at 5:11