cckec / winetricks

Automatically exported from code.google.com/p/winetricks
0 stars 0 forks source link

avoid misuse of killall on Solaris #77

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
On Solaris, the killall command works differently than the command which has 
the same name on BSD or Linux. Its synopsis is "kill all active processes":

  http://download.oracle.com/docs/cd/E19253-01/816-5166/killall-1m/index.html
  http://download.oracle.com/docs/cd/E18752_01/html/816-5166/killall-1m.html
  http://search.oracle.com/search/search?q=killall

This is not what is needed in winetricks.

This untested patch replaces the BSD/Linux usage of killall in four places with 
a more portable, and much less dangerous, construct.

In Issue 71, I use the same construct. It may be desirable to turn it into a 
winetricks_killall verb.

Original issue reported on code.google.com by t...@hush.ai on 15 May 2011 at 2:50

Attachments:

GoogleCodeExporter commented 8 years ago
Looks good... please do make a helper function.

Original comment by daniel.r...@gmail.com on 15 May 2011 at 3:00

GoogleCodeExporter commented 8 years ago
Here it is as a function. I tested it with the DC2BA and Q3A demos under Linux.

Original comment by t...@hush.ai on 15 May 2011 at 6:09

Attachments:

GoogleCodeExporter commented 8 years ago
Please post real name so we can attribute properly.

Original comment by austinenglish@gmail.com on 26 Oct 2011 at 6:42

GoogleCodeExporter commented 8 years ago
I committed a cleaner version in r967.

Original comment by austinenglish@gmail.com on 15 Jun 2013 at 8:48