search

cclaerhout / xen_BBM_v2

Version 2 of the BbCodes and Buttons Manager (BBM) for XenForo (working with TinyMCE 4)
6 stars 1 forks source link

Preview of a bbcode using parser permissions doesn't work as expected #10

Closed Xon closed 9 years ago

Xon commented 9 years ago

When previewing a bbcode using parser permissions, the bbcode doesn't render if it is locked to a group the user making the post is a member of.

Likely this is a code-path not setting up the tag-map, and as such the parser permissions don't know about the use group properly.

cclaerhout commented 9 years ago

I'm going to follow your lead for this ; would it be just possible to keep brackets for conditionnals ? I prefere to keep the well organized structure for PHP ; for JS it's different ^^

Xon commented 9 years ago

Whoops. I normally put brackets around conditionals. I must have missed some. I'll re-tab this so the code matches the surrounding code.

cclaerhout commented 9 years ago

So your patch fixes this issue, can you confirm please, so it can be closed, thanks

Xon commented 9 years ago

Yes. I've been running this in production for ~2 days now and it is working fine.