search

cclark2a / SchmickleWorks

VCV Rack Modules
The Unlicense
14 stars 0 forks source link

INT_MAX still a problem (easy fix) #8

Closed davephillips closed 5 years ago

davephillips commented 5 years ago

Greetings ! Thanks for the quick fix for my previous issue. I hit this one again too:

$ make dist
g++  -Wsuggest-override -std=c++11  -DSLUG=SchmickleWorks-NoteTaker -fPIC -I../../include -I../../dep/include -DVERSION=0.6.0 -MMD -MP -g -O3 -march=athlon-fx -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/UnitTest.cpp.o src/UnitTest.cpp
In file included from src/UnitTest.cpp:6:0:
src/NoteTaker.hpp:94:26: error: ‘INT_MAX’ was not declared in this scope
     int lastHorizontal = INT_MAX;
                          ^
src/NoteTaker.hpp:95:24: error: ‘INT_MAX’ was not declared in this scope
     int lastVertical = INT_MAX;
                        ^
../../compile.mk:64: recipe for target 'build/src/UnitTest.cpp.o' failed
make: *** [build/src/UnitTest.cpp.o] Error 1

The error is probably thrown by my old compiler (GCC 5.3.1) and may not show for others. Again the easy fix for this is to add

#include <limits.h>

to NoteTaker.hpp

cclark2a commented 5 years ago

Moved system includes into common header, may prevent this sort of thing from happening again. Maybe.