search

cclgroupltd / ccl_chromium_reader

(Sometimes partial) Python re-implementations of the technologies involved in reading various data sources in Chrome-esque applications.
MIT License
134 stars 34 forks source link

Tweaks #16

Closed jauntywunderkind closed 3 months ago

jauntywunderkind commented 1 year ago

Hello. I've been interested in reading my own snss & indexeddb data out, to better track my own activity over time.

I found a couple modest tweaks that I needed to make use of this library. Please let me know if there's anything I can do to help get some or all of these changes merged in.

jauntywunderkind commented 1 year ago

Thanks for the fast comments, much appreciated! I've tried to bring things closer in line to what you've said.

I really like that we can avoid doing the get_blob_info lookup twice now, which was kind of expensive ("goodness me this is a slow way of doing things,").

I don't really know much about python packaging/library situations to be honest. On Debian my system had all these libraries available (except win32), except the the system python3-pycryptodome gets installed installed as Cryptodome not Crypto. I wouldn't know what to do to try to do to create some kind of virtual env where I could safely install python packages without affecting my whole system. The changes I made are reverted out, so there's both a record of what someone needs to do, while not affecting the current behavior. In https://github.com/cclgroupltd/ccl_chrome_indexeddb/issues/15#issuecomment-1383875083 I saw mention of a try import which I didn't know about; in a future PR I might try using that to make audit better able to fallback to Linux runnability, but I don't expect to do that exploration in this PR.