Can't download original image after site update

fururebyworks commented 1 year ago

Is it just me? Resize image is downloaded after clicking Download Archive. Force download resize image is uncheck in advanced.

ccloli commented 1 year ago

Without any further information like screenshot, gallery url or log in console, I'd say "Yep, you, only you, just you, you're the chosen one". 🤣

Check if the zip file matches gallery's file size first, then see which page goes wrong and whether that page has the "download original image" link. To get a copy of runtime log, press F12 and switch to Console, start download, then copy all the logs started with [EHD] then paste it here.

suzumiyang commented 1 year ago

Me too. 103m on gallery, 3m zip.

suzumiyang commented 1 year ago

here is all my log [EHD] E-Hentai Downloader is running. userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:39 [EHD] Bugs Report > https://github.com/ccloli/E-Hentai-Downloader/issues | https://greasyfork.org/scripts/10379-e-hentai-downloader/feedback userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:40 [EHD] To report a bug, it's recommended to provide the logs started with "[EHD]", thanks. =w= userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:12322 [EHD] UserAgent > Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/118.0.0.0 Safari/537.36 userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:12323 [EHD] Script Handler > Tampermonkey userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:12324 [EHD] Script Handler Version > 4.19.0 userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:12325 [EHD] E-Hentai Downloader Version > 1.34.10 userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:12326 [EHD] Current URL > https://exhentai.org/g/2722860/13e3010d0f/ userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:12327 [EHD] Is Logged In > true userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:12286 [EHD] E-Hentai Downloader Setting > {"thread-count":5,"timeout":0,"speed-detect":false,"retry-count":6,"delay-request":0,"number-images":true,"number-separator":"_","number-real-index":true,"number-auto-retry":true,"auto-download-cancel":true,"dir-name":"/","file-name":"{subtitle}","recheck-file-name":false,"ignore-torrent":true,"status-in-title":"always","hide-image-limits":false,"hide-estimated-cost":false,"file-descriptor":false,"force-resized":false,"never-new-url":false,"never-send-nl":false,"never-warn-peak-hours":false,"never-warn-large-gallery":true,"store-in-fs":true,"play-silent-music":true,"save-info":"file","save-info-list":["title","metas","uploader-comment","page-links"],"save-info-list[]":false,"replace-with-full-width":true,"force-pause":false,"save-as-cbz":false,"pass-cookies":false,"force-as-login":false} userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:14680 [EHD] Request Resolution Setting userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:14542 [EHD] Request Image Limits From e-hentai.org userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:12122 [EHD] File System is opened! Name > https_exhentai.org_0:Temporary userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:14692 [EHD] Resolution Setting > {"withoutHentaiAtHome":0,"resolution":1,"originalImages":0,"timestamp":1698756665512} userscript.html?name=E-Hentai-Downloader.user.js&id=c9d1b0dc-6d6a-49ba-8c49-bf76fd0b2f92:14570 [EHD] Image Limits > {"timestamp":1698756665621,"cur":"0","total":"50000","donatorPower":0} 13e3010d0f/:1 Uncaught SyntaxError: Unexpected end of JSON input at JSON.parse () at xhr.onreadystatechange (userscript.html?name=X2Convert-Button.user.js&id=88c8c382-d872-440b-aa0c-2bb62a901c8d:353:591) ip.x2convert.com/checkcookie.ashx:1

   Failed to load resource: net::ERR_CERT_DATE_INVALID

goooooodperson commented 1 year ago

Me too,My log is similar to the above. I'd say it happened about six hours ago.

ccloli commented 1 year ago

six hours ago

That makes sense, since I just tested the function yesterday. Should have a look at it whe I arrived at home.

suzumiyang commented 1 year ago

six hours ago

That makes sense, since I just tested the function yesterday. Should have a look at it whe I arrived at home.

Thank you

ccloli commented 1 year ago

Looks like the original image link format has been changed from https://e-hentai.org/fullimg.php?gid=2722913&page=15&key=ofk0lkwa43p to https://e-hentai.org/fullimg/2722913/15/ofk0lkwa43p/112653370_p0.jpg.

Although the site update happened a few days ago didn't break the script, because the script is matched by url regex pattern, today EH changes the url format, so for now the original image download is not available because the script cannot find the old pattern.

goooooodperson commented 1 year ago

Looks like the original image link format has been changed from https://e-hentai.org/fullimg.php?gid=2722913&page=15&key=ofk0lkwa43p to https://e-hentai.org/fullimg/2722913/15/ofk0lkwa43p/112653370_p0.jpg.

Although the site update happened a few days ago didn't break the script, because the script is matched by url regex pattern, today EH changes the url format, so for now the original image download is not available because the script cannot find the old pattern.

Thank you, my hero! I change the (\S+?\/fullimg.php\?\S+?) to (\S+?\/fullimg\/\S+?) in regex and "fullimg.php" to "fullimg/" in indexOf function. It seems to be working fine again.

ccloli commented 1 year ago

v1.35 is released, sorry it's a bit late, was fixed at least half an hour ago, but since there are some changes I made in local and haven't pushed to remote, so I'm pushing them together.

These changes was going to be released in a new y version, but didn't fully finish yet. so I was resolving conflicts and addressing some new issues, then forget it just yolo. Hope it doesn't have too many bugs. 🤣

70338 commented 1 year ago

e-h update today(2023/10/31) change something. The original image URL has changed to other websites, and it seems to be floating. Moreover, those URLs are unstable, and some images are difficult to load. Due to the change in the website policy, I am not sure if obtaining the original image requires a higher level. (I have bought bronze star aready,wish I dont need to upgrade to sliver.) Thank you for developing and fixing it.

ccloli commented 1 year ago

Moreover, those URLs are unstable, and some images are difficult to load.

Because original images is also delivered by Hentai@Home now, see EH update log.

- H@H High-Capacity Ranges are now live. This change lets us efficiently take advantage of surplus H@H capacity for original images with some limitations.

Specifically, the system will now use H@H for original images smaller than 10 MiB in galleries that were posted in the last year, assuming that you haven't changed the H@H setting under "Image Load Settings" to "Default port clients only" or "No". Otherwise, it will still use the regular image servers.

This change applies for regular browsing when "Prefer original images" is selected and the file would normally be resampled at 2400x, when using the "Download Original" button, and when using the H@H Downloader.

v1.35 somehow addresses the problem by appending nl parameter, for details, see previous issue #256.

The original image URL has changed to other websites, and it seems to be floating.

The update log has been updated, too. It's to fix a bug on Firefox.

- We now do an URL rewrite for fullimg requests to fix an issue specific to Firefox where files were sometimes being saved as "fullimg.php"

Due to the change in the website policy, I am not sure if obtaining the original image requires a higher level. (I have bought bronze star aready,wish I dont need to upgrade to sliver.)

Then you should use the offical archiver, for bronze star you can get 5GB to download in a week for free.

70338 commented 1 year ago

It works now! Thank you!

Triramama commented 1 year ago

After this update, when I exceed my viewing quota download doesn't stop automatically and gives me the warning, instead download starts consuming my gp, lost a couple thousand on a gallery that's not even 12 month old already, would appreciate if you could look into it.

ccloli commented 1 year ago

@Triramama Sorry to hear that, maybe the site updates also changes something else. Since it's not related to this issue, for further tracking purpose and keep tidy, I'm going open a new issue.

ccloli / E-Hentai-Downloader

Can't download original image after site update #259