ccloli / E-Hentai-Downloader

Download E-Hentai archive as zip file
GNU General Public License v3.0
1.87k stars 138 forks source link

bug report 1.35.2 #275

Open etybgm opened 10 months ago

etybgm commented 10 months ago

1.35.2 Show inputs to recheck file name and folder name before downloading: (C100) [焼肉定食 (ハラミ)] もしも担当アイドル北沢志保と付き合ったら ~後編~ (アイドルマスター ミリオンライブ!) Completed: (C100) [焼肉定食 (ハラミ)] もしも担当アイドル北沢志保と付き合ったら 後編 (アイドルマスター ミリオンライブ!).zip

~->_

ccloli commented 10 months ago

I remembered it's intended, probably because ~ is the user home directory on *nix, and can be used as short file name in DOS.

But I checked it just now, it seems that it's allowed on most systems. If it's fine then I'll remove it from disallowed symbols in next version.

ccloli commented 4 weeks ago

Checked the source code just now:

    var replaceList = {
        ':': ':',
        '"': '"',
        '*': '*',
        '?': '?',
        '|': '|',
        '<': '<',
        '>': '>',
        '/': '/',
        '\\': '\',
        '\n': '-'
    };

Seems that ~ is not in the list, even in the first version which introduced the the feature.

image

Besides, the script replace these symbols into - instead of _. So I'm aware the filename is changed by the browser itself, not on the script side.

etybgm commented 4 weeks ago

Can I replace the symbol ~ with the full-width ~ in script side?