search

ccloli / E-Hentai-Downloader

Download E-Hentai archive as zip file
GNU General Public License v3.0
1.9k stars 140 forks source link

[Request] Add a pause/resume button #30

Closed nodevicefound closed 8 years ago

nodevicefound commented 8 years ago

Can you please add a pause/resume button on the download status mini screen?

Sometimes if the gallery size is big, after more than 30% or 50% have been downloaded, I remember something more important. So I have to close the tab and download again later. But my image limits are consumed due to the previous partial downloading. So, a pause/resume button would be appreciated.

ccloli commented 8 years ago

I understand, but here is a problem that has been mentioned in https://github.com/ccloli/E-Hentai-Downloader/issues/5#issuecomment-136361378 : we can't get downloaded part if download is not finished. So if we pause (or say abort, in fact) all the downloading requests, the downloading images will have to be re-downloaded.

However, the images that have been downloaded will be kept in RAM, so they won't have to download again, just hold some RAM space. If you think it's acceptable, I'll try to work it out in next version, it seems that it's not hard.

* Update: typo

nodevicefound commented 8 years ago

Yes of course I understand that those downloaded images will hold some RAM space until the whole gallery gets downloaded. This should be acceptable for everyone. I will look forward to the next version. Thanks a lot for your time.

ccloli commented 8 years ago

Sorry for keep waiting too long, in these months here are some serious bugs (or even on script handler) so that I can't work on it. Now this feature is added in 1.22, after updated, you'll see the pause button when downloading.

It won't abort downloading images by default, you can let them aborted by changing its behavior on Settings > Advanced > Force drop downloading images data when pausing download.

By the way, as Tampermonkey/tampermonkey#298 is not fixed right now, you may meet some problems on Tampermonkey. This feature probably can't work correctly on Tampermonkey (mostly for Chrome user), so please try GreaseMonkey (Firefox only) if needed.

iShyboy commented 8 years ago

Worked fine in my FF, but could you change where the button is? Like in the 'on hover' line that appear or in the infobar at the top, the one with total|downloads|fails

ccloli commented 8 years ago

@iShyboy I'm not sure it will be useful, with keeping showing in bottom, users can know this feature and current status (pausing or not). If showing when mouse hover, it would also cover the progress table so that you can't abort some connections. And if showing on top, does it take too much place?