Closed brcb20 closed 4 years ago
This is a good catch. I propose [id]-[title] to keep it a little human-readable while still being unique.
On Mon, Nov 4, 2019, 10:20 AM Benjamin B notifications@github.com wrote:
Using the artpiece title as the key in the canvas locations dict requires the title to be unique, which is currently not the case.
Here is the output of a test where multiple artpieces had the same title:
Loaded 9 pieces of art id title email submit_date 0 1 emptylife benjamin_bell01@yahoo.fr 2019-11-01 08:50:51.523877 1 3 testing benjamin_bel@yahoo.fr 2019-11-02 18:32:28.896644 2 4 testing benjam_bel@yahoo.fr 2019-11-02 18:33:50.484726 3 5 testing benam_bel@yahoo.fr 2019-11-02 18:35:30.279089 4 6 testing bam_bel@yahoo.fr 2019-11-02 18:35:40.530724 5 7 testing bafjkakshfkm_bel@yahoo.fr 2019-11-02 18:35:59.110492 6 8 test2 hello@gmail.com 2019-11-02 18:36:52.334093 7 9 test2 helo@gmail.com 2019-11-02 18:38:34.823016 8 10 test3 bye@gmail.com 2019-11-02 18:38:50.019582 Successfully generated artistic procedure into: ARTBot/robot/procedures/ARTISTIC_PROCEDURE_20191104-100700.py The following slots will be used: Slot 1: "emptylife" Slot 6: "testing" Slot 8: "test2" Slot 9: "test3"
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cclrobotics/ARTBot/issues/37?email_source=notifications&email_token=AEB3IRX7LHEOASWBIUCQ6VDQSBRWPA5CNFSM4JIXLZZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HWVWZJA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEB3IRRAZXXOYTZQTHU365TQSBRWPANCNFSM4JIXLZZQ .
Using the artpiece title as the key in the canvas locations dict requires the title to be unique, which is currently not the case.
Here is the output of a test where multiple artpieces had the same title: