search

ccmenu / ccmenu

CCMenu is a Mac application to monitor continuous integration servers.
https://ccmenu.github.io/ccmenu
Other
337 stars 40 forks source link

Enlarged add job window horizontally #87

Closed ssbarnea closed 6 years ago

ssbarnea commented 7 years ago

Fixes #80 and below you can see the new window layout:

ccmenu-resize-2 ccmenu-resize-1

ssbarnea commented 7 years ago

@erikdoe If you could have a look at this it would be great.

As you can observe there are few other side effects of editing the project with a newer version of XCode. Still, these added xml properties should not affect use of older versions of XCode.

jacksonjesse commented 6 years ago

I'm not particularly qualified as a Mac OS developer so hard for me to understand the exact change, but to clarify, is this just making the window a wider fixed width, or actually allowing the window to be made wider?

ssbarnea commented 6 years ago

@jacksonjesse Is not making it resizable as I don't know exactly how to do this myself. Still, it does enlarge it to the size you see on the screenshot, which is only a little bit bigger than the main config window.

This is the the safest approach as it would avoid making it bigger than then the narrowest monitor.

I hope @erikdoe will merge this sooner and make a new release as is really painful to have to run my own build just to be able to use ccmenu.

TBH, I don't care if this is merges as is or if he decides to make a similar change directly and push it as long it goes ccmenu. The current width are just far too small.

erikdoe commented 6 years ago

I've just made a commit that makes the sheet resizable (fbe881b08b8c5c48e1ce23a01c004922c036beac). Can you double-check that this works for you?

In a second commit I've also changed the truncating mode to "middle", meaning thatlong project names will be shortened in the middle, keeping the last part visible. Is that helpful?

jacksonjesse commented 6 years ago

Yep quick tests suggests this is exactly what I'm after!

ssbarnea commented 6 years ago

@erikdoe Thanks for doing that! Yes, resize works well and also middle-trunction mode.

On the other hand I found a bug that I didn't see so far, clearly unrelated to those changes. https://github.com/erikdoe/ccmenu/issues/99