search

ccnet / CruiseControl.NET

CruiseControl.NET is an Automated Continuous Integration server, implemented using the .NET Framework. Downloads at sourceforge. The documentation can be found at:
https://ccnet.github.io/CruiseControl.NET
Other
409 stars 225 forks source link

QueueDuplicateHandlingMode extra option to always add #295

Open PonchoPowers opened 4 years ago

PonchoPowers commented 4 years ago

Are you okay with me sending a pull request to make a slight change to the way duplicates are handled? I'm using CruiseControl.NET in a slightly different way to the convention and rather than patching each update it would be much easier if I could make a slight code change that will benefit the community that also makes sense to offer as an option.

In IntegrationQueue.cs there is a swtich that handles duplicates, and I'd like to change the switch so that there is another option: QueueDuplicateHandlingMode.AddAdditional

This will allow people to force multiple builds as opposed to one, which in my scenario makes sense.

If you are okay with me making this change I'll create a pull request?

By adding a new handling mode the original functionality is retained but an additional option is provided so that I can use CruiseControl.NET in a more useful way.

PonchoPowers commented 4 years ago

There is also a bug with the ccnet.xsd with ApplyForceBuildsReAddTop being missing which I can fix in the PR.

RubenWillems commented 4 years ago

Hi

sure an extra option is the preferred way, the default value should stay the same as it is now

with kind regards Ruben Willems

On Mon, 16 Nov 2020 at 06:06, Matthew Bonner notifications@github.com wrote:

Are you okay with me sending a pull request to make a slight change to the way duplicates are handled? I'm using CruiseControl.NET in a slightly different way to the convention and rather than patching each update it would be much easier if I could make a slight code change that will benefit the community that also makes sense to offer as an option.

In IntegrationQueue.cs there is a swtich that handles duplicates, and I'd like to change the switch so that there is another option: QueueDuplicateHandlingMode.AddAdditional

This will allow people to force multiple builds as opposed to one, which in my scenario makes sense.

If you are okay with me making this change I'll create a pull request?

By adding a new handling mode the original functionality is retained but an additional option is provided so that I can use CruiseControl.NET in a more useful way.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ccnet/CruiseControl.NET/issues/295, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUZAO4YKPPHAIEI3HLLADSQCXL3ANCNFSM4TWWHNWQ .

RubenWillems commented 4 years ago

Hi

If this bug has nothing to do with that new option, make a new pull request.

with kind regards Ruben Willems

On Mon, 16 Nov 2020 at 06:13, Matthew Bonner notifications@github.com wrote:

There is also a bug with the ccnet.xsd with ApplyForceBuildsReAddTop being missing which I can fix in the PR.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ccnet/CruiseControl.NET/issues/295#issuecomment-727738775, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUZALQ2HSZAFEOIJZJHULSQCYI7ANCNFSM4TWWHNWQ .