search

ccoenraets / OpenFB

Micro-library that lets you integrate browser and Cordova apps with Facebook with no plugin or SDK dependency.
MIT License
507 stars 229 forks source link

- added inAppBrowserOptions in calling openfb api; #122

Open IvanProdaiko94 opened 7 years ago

IvanProdaiko94 commented 7 years ago

The problem this commit will solve is an ability to use inAppBrowser behaviour while using "openFB".

In my resent project (it was about cutting of videos) I have faced the problem, that after using libruary all videos that had inline attribute stops to play inline on IOS. As far as I understood, parameters that you pass to inAppBrowser after it closing will be applied to your main window. Unfortunately I had no ability to control this behaviour while using "openFB", but this these small chenges I can do it.

nosovk commented 7 years ago

Isn't better solution to add separate setOptions/getOptions methods into InAppBrowser instead of patching library that depends on it? That way we can save and restore settings of IAB. But this is also a solution, cause it will not break anything.