search

ccojocar / sso-operator

Single Sign-On Kubernetes operator for Dex identity provider
Apache License 2.0
78 stars 20 forks source link

Refs jenkins-x/sso-operator#22 #23

Closed brunnels closed 5 years ago

brunnels commented 5 years ago

Added UrlTemplate to SSO.Spec to allow setting the urltemplate in the exposeconttroller configmap Added a check to not add ingress annotation if CertIssuerName is not defined in the SSO.Spec

jenkins-x-bot commented 5 years ago

Hi @brunnels. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ccojocar commented 5 years ago

/test this

ccojocar commented 5 years ago

Please could you fix the lint warning:

+ make all
go get -u github.com/golang/dep/cmd/dep
INSTALLING DEPENDENCIES
/home/jenkins/go/bin/dep ensure 
FORMATTING
go get -u golang.org/x/lint/golint
VETTING
go vet 
LINTING
/home/jenkins/go/bin/golint -set_exit_status github.com/jenkins-x/sso-operator github.com/jenkins-x/sso-operator/pkg/apis/jenkins.io github.com/jenkins-x/sso-operator/pkg/apis/jenkins.io/v1 github.com/jenkins-x/sso-operator/pkg/client/clientset/versioned github.com/jenkins-x/sso-operator/pkg/client/clientset/versioned/fake github.com/jenkins-x/sso-operator/pkg/client/clientset/versioned/scheme github.com/jenkins-x/sso-operator/pkg/client/clientset/versioned/typed/jenkins.io/v1 github.com/jenkins-x/sso-operator/pkg/client/clientset/versioned/typed/jenkins.io/v1/fake github.com/jenkins-x/sso-operator/pkg/client/informers/externalversions github.com/jenkins-x/sso-operator/pkg/client/informers/externalversions/internalinterfaces github.com/jenkins-x/sso-operator/pkg/client/informers/externalversions/jenkins.io github.com/jenkins-x/sso-operator/pkg/client/informers/externalversions/jenkins.io/v1 github.com/jenkins-x/sso-operator/pkg/client/listers/jenkins.io/v1 github.com/jenkins-x/sso-operator/pkg/dex github.com/jenkins-x/sso-operator/pkg/kubernetes github.com/jenkins-x/sso-operator/pkg/operator github.com/jenkins-x/sso-operator/pkg/proxy
/home/jenkins/go/src/github.com/jenkins-x/sso-operator/pkg/apis/jenkins.io/v1/types.go:46:2: struct field UrlTemplate should be URLTemplate
/home/jenkins/go/src/github.com/jenkins-x/sso-operator/pkg/proxy/expose.go:254:2: struct field UrlTemplate should be URLTemplate
Found 2 lint suggestions; failing.
Makefile:48: recipe for target 'lint' failed
make: *** [lint] Error 1
brunnels commented 5 years ago

Done, sry forgot to make fmt && make lint

ccojocar commented 5 years ago

/ok-to-test /lgtm /test this

jenkins-x-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x/sso-operator/blob/master/OWNERS)~~ [ccojocar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment