ccojocar / sso-operator

Single Sign-On Kubernetes operator for Dex identity provider
Apache License 2.0
78 stars 20 forks source link

chore: Add missing simple cases to proxy buildName function #26

Closed romainverduci closed 5 years ago

romainverduci commented 5 years ago

Follow up https://github.com/jenkins-x/sso-operator/pull/25. There was 2 missing cases not handled by the buildName function.

ccojocar commented 5 years ago

/lgtm

jenkins-x-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x/sso-operator/blob/master/OWNERS)~~ [ccojocar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment