search

ccojocar / sso-operator

Single Sign-On Kubernetes operator for Dex identity provider
Apache License 2.0
78 stars 20 forks source link

chore: add linter and config #51

Closed garethjevans closed 4 years ago

jenkins-x-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: garethjevans

If they are not already assigned, you can assign the PR to them by writing /assign @garethjevans in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x/sso-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pmuir commented 4 years ago

/retest

pmuir commented 4 years ago

@garethjevans what do we want to do with this PR?

jenkins-x-bot commented 4 years ago

@garethjevans: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint 249863ac1cfeefb619ccc733e6cc206202d5eb22 link /test lint
pr-build 249863ac1cfeefb619ccc733e6cc206202d5eb22 link /test this

View all Builds for this Pull Request

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ccojocar commented 4 years ago

Closing this since the build is failing. I think that it requires a bit more work to migrate it over to Go modules.