search

ccojocar / sso-operator

Single Sign-On Kubernetes operator for Dex identity provider
Apache License 2.0
78 stars 20 forks source link

fix: use of k8s API to read secret Data field #55

Closed mtl-wgtwo closed 4 years ago

mtl-wgtwo commented 4 years ago

StringData is a write-only field and is not output by the API. Instead, we need to read the Data field and convert to a string.

Also adds some small logging to emit errors if any are found.

mtl-wgtwo commented 4 years ago

/assign @garethjevans

mtl-wgtwo commented 4 years ago

Anything I need to do on this one to help it along?

mtl-wgtwo commented 4 years ago

/assign @ccojocar

Pinging @ccojocar @garethjevans for approval

ccojocar commented 4 years ago

/lgtm

ccojocar commented 4 years ago

/approve

jenkins-x-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](jenkins-x/sso-operator/blob/master/OWNERS)~~ [ccojocar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jenkins-x-bot commented 4 years ago

@mtl-wgtwo: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint f65c634922e139aecbd2ea56fe9c1303c231e36f link /test lint
pr-build f65c634922e139aecbd2ea56fe9c1303c231e36f link /test this

View all Builds for this Pull Request

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).