search

ccomeaux / boardgamegeek4android

BoardGameGeek application for Android (unofficial)
GNU General Public License v3.0
228 stars 47 forks source link

Add translation files (pl-PL, Polish) #126

Closed Kaligula0 closed 4 years ago

Kaligula0 commented 4 years ago

Polish (pl-PL) translation files – ready for use. Yay.

Kaligula0 commented 4 years ago

1) There are some plurals that I had to use <item quantity="few"> in. In Polish few = "numbers ending 2, 3, or 4 but not 12, 13, or 14" – as stated on https://developer.android.com/guide/topics/resources/string-resource#Plurals (and I agree) 2) If (in plurals) there's only one item left ("other") – should this be left still as plural or become a string? I believe that plural, but thought I'd better ask. 3) There are 2 lines in strings.xml (559 and 563), where I see this should be a plural in Polish (quantities "one" and "other"). Should I: a) add there a tools:ignore="PluralsCandidate" attribute or b) this attribute should be added also in "/values" directory or c) should we make this plural in both places now d) should we do nothing now? 4) Line 73 (string "or"). It's used in CollectionStatusFilterDialog.kt and PlayStatsFragment.kt. The case is, when strictly translated it sounds perfect in the 1st use and lets say "O.K." in latter. Well, it can work as it is. But will definitely sound better in Polish if this string is separated into two strings: "or"→pl:"lub" (for 1st use) and "nor"→pl:"ani" (for 2nd use). I can make it in this pull request (add new string here, new string in /values and edit PlayStatsFragment.kt).

ccomeaux commented 4 years ago

Looks like I merged too early. @Kaligula0 - for plurals, we need to provide one, few, andmanyfor all entries.other` appears to be optional.