ccomeaux / boardgamegeek4android

BoardGameGeek application for Android (unofficial)
GNU General Public License v3.0
228 stars 47 forks source link

Tapping game from collection / search results often crashes #137

Closed zefquaavius closed 4 years ago

zefquaavius commented 4 years ago

Tapping on a game from the [possibly filtered] collection or search results often crashes shortly after it starts trying to load the game data, at least on a Samsung Galaxy A20. I usually can work around by getting to the game through the Plays. So for a new game, I have to log a generic play on BGG; then I can open it in this app and manipulate all the details in your much more pleasant way.

Thanks! Keep up the good work!

ccomeaux commented 4 years ago

What version of the app is this on?

zefquaavius commented 4 years ago

Great question. That's the new release candidate, but it was also doing that in the prior version from a few months ago. I just had been too busy to complain about it. :^/

Thanks! N

On Sat, Apr 18, 2020 at 9:21 AM Chris Comeaux notifications@github.com wrote:

What version of the app is this on?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ccomeaux/boardgamegeek4android/issues/137#issuecomment-615870253, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENTRAVTRKVCTWH7VP64QJDRNGSN7ANCNFSM4MLLF6LQ .

zefquaavius commented 4 years ago

Is there a way I can send you logged crash info, or is the app collecting that already?

On Sat, Apr 18, 2020 at 9:56 AM Nathan Morse zefquaavius@gmail.com wrote:

Great question. That's the new release candidate, but it was also doing that in the prior version from a few months ago. I just had been too busy to complain about it. :^/

Thanks! N

On Sat, Apr 18, 2020 at 9:21 AM Chris Comeaux notifications@github.com wrote:

What version of the app is this on?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ccomeaux/boardgamegeek4android/issues/137#issuecomment-615870253, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENTRAVTRKVCTWH7VP64QJDRNGSN7ANCNFSM4MLLF6LQ .

Kaligula0 commented 4 years ago

I don't have this problem, so this should be related to conflict between app and specific OS. What Android version do you use? Mine is Android 9.

zefquaavius commented 4 years ago

Good question. I forgot to include that: version 9, kernel 4.4.111-16481871

On Sun, Apr 19, 2020 at 7:23 PM Vinne2 notifications@github.com wrote:

I don't have this problem, so this should be related to conflict between app and specific OS. What Android version do you use? Mine is Android 9.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ccomeaux/boardgamegeek4android/issues/137#issuecomment-616242728, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENTRAS4HM6TBS6RUUQ7BUTRNOBYTANCNFSM4MLLF6LQ .

ccomeaux commented 4 years ago

Can you see if you have "Debug" checked in Advanced Settings? If so, try disabling it and see if the problem is resolved.

zefquaavius commented 4 years ago

Holy cow!!!! You mean all this time this has not been behaving on this device, it's because I had debug mode on? Suddenly, it's loading game info in full when I select a game, which had never been a problem on any prior device, but had never worked even once on this one. I couldn't figure out what was going on. It was also a new version of this app for me, so it was just too many variables to bother you about the possibility of it being the fabulous app's fault.

I'm quite shocked that debug mode causes many features not to work.

I just (with debug off) told it to resync the collection. This should be liberating and empowering! Thank you for the help, and for continuing to develop your amazing app, Chris! N

On Tue, Apr 28, 2020 at 8:17 AM Chris Comeaux notifications@github.com wrote:

Can you see if you have "Debug" checked in Advanced Settings? If so, try disabling it and see if the problem is resolved.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ccomeaux/boardgamegeek4android/issues/137#issuecomment-620568924, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENTRAWFHO5TIOHMJ63DINTRO3COBANCNFSM4MLLF6LQ .

ccomeaux commented 4 years ago

Well, that's my fault. I put debug mode in place to try to figure out why some people had problems similar to yours. My guess is that I figured out the majority of the problems, then caused some more with my hacky debug code. I'll rip it out completely for the next iteration of the app.

zefquaavius commented 4 years ago

No problem! When I had troubles, I thought I'd turned it off as an experiment; clearly not!

It is really great seeing all the new, glorious functionality.

Thank you so much! N

On Wed, Apr 29, 2020 at 1:41 PM Chris Comeaux notifications@github.com wrote:

Well, that's my fault. I put debug mode in place to try to figure out why some people had problems similar to yours. My guess is that I figured out the majority of the problems, then caused some more with my hacky debug code. I'll rip it out completely for the next iteration of the app.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ccomeaux/boardgamegeek4android/issues/137#issuecomment-621360450, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENTRAVWHM24SBWXO2PRH6TRPBRDBANCNFSM4MLLF6LQ .