ccomeaux / boardgamegeek4android

BoardGameGeek application for Android (unofficial)
GNU General Public License v3.0
228 stars 47 forks source link

Can't save fractional prices in Private info (on non-English OS) #139

Open Kaligula0 opened 4 years ago

Kaligula0 commented 4 years ago

As @KleineGelbe reported on BGG Guild. Some countries use comma, some use period (full stop) as a decimal separator. – In app it is impossible to input a comma in Private info > Price Paid (or Current Price), simply nothing happens. – Using period and saving – results in number being treated as if there were only digits and no period: "9.90"->"990", "9.0"->"90". I think that's because some countries use period as optional visual thousands separator so maybe OS omits that while saving numbers.

Both chars work on BGG website when you open any boardgame page > click button [✔ In Collection▾] > [Edit] and input price. BUT from the Collection view: 1) period works well, 2) when using comma, everything after comma gets stripped.

(Switching OS language to English temporary solves the issue.)

(Not sure if related to #136.)

Kaligula0 commented 4 years ago

(I updated previous comment.)

EDITING PRICE FIELDS

1) When I input e.g. "7.99" and hit OK – it shows "799,00". 2) Right after that (before saving and syncing changes) I try to edit it – erase nines, replace zeros with nines, preserving the comma, hit OK, it shows "7,99". 3) I hit ✔. Looks like it's syncing. 4) Still "7,99" in app, but on BGG website it's already "7.00". 5) I go back (to [My games] tab), it syncs and then shows "7.00". Tadaaam

And one more thing: if I input a price on BGG website (e.g. "7.99") it shows up as "7,99" on website and as "7,99" (comma!) in app. When I edit Private info in app it still shows "7.99" (period!) in the text field. But when I click OK (even if I don't touch the price field) the app omits the period and makes "799,00" (visible before saving changes).

Kaligula0 commented 2 years ago

Does that eeb2278a779d5968fcb18fe73c2cb8e379c5ea0c help also with this issue? :thinking: