search

ccomeaux / boardgamegeek4android

BoardGameGeek application for Android (unofficial)
GNU General Public License v3.0
228 stars 47 forks source link

Added BGG Link icon to game toolbar #149

Closed lehenry closed 3 years ago

lehenry commented 4 years ago

I often find myself going to the BGG page - it makes sense to have the BGG link right on the toolbar, similar to the way it is displayed on the forum thread, instead of have to scroll to the link tab and select the link there.

Kaligula0 commented 4 years ago

Good point! I never thought of improving this feature (link to BGG gamepage). However, I'm not a fan of duplicating menu options, so what do you think of making the TITLE of the game link to BGG website? For now the Title is inactive, it's clearly only for display. It might get itself a function…? ;) sketch-1590227568078

Well, the last word belongs to ccomeaux, nevertheless...

Kaligula0 commented 4 years ago

P.S. And thanks for finding a typo in my PL translation… 😅 Sorry for you having to see this…

lehenry commented 4 years ago

Making the title the link would work for me, but there wouldn't be any cue for the user.

On the other end the header already has multiple menu options in the thread page, so it would be consistent across the application - which is a good UX principle. image

Kaligula0 commented 4 years ago

I strongly agree with you! You convinced me. ;)

ccomeaux commented 3 years ago

@lehenry can you look to resolve the conflict please? I'll get it merged and released before the end of the year. Thanks!

lehenry commented 3 years ago

@ccomeaux conflicts resolved, ready to merge