ccomeaux / boardgamegeek4android

BoardGameGeek application for Android (unofficial)
GNU General Public License v3.0
226 stars 47 forks source link

bad rendering of (some) diacritics/Unicode in game description #150

Open Kaligula0 opened 4 years ago

Kaligula0 commented 4 years ago

https://www.boardgamegeek.com/boardgame/33458/carcassonne-expansion-6-count-king-robber should have "by Hans im Glück" but renders "by Hans im Glück". Screenshot_20200531-145233

Also https://www.boardgamegeek.com/boardgame/18836/Carcassonne-river-II should have "contained in Carcassonne: Expansion 6 – Count, King & Robber" but renders "contained in Carcassonne: Expansion 6 – Count, King & Robber". Screenshot_20200601-124845

ccomeaux commented 4 years ago

This is a bug in the BGG API. In the first example you show, it's returning ü instead of ü. I believe this is due to double encoding. I've tried to reverse this, but I haven't been able to find a way.

Kaligula0 commented 4 years ago

Ah, now I see. I filed a bug → https://boardgamegeek.com/thread/2446951/api-generates-wrong-entities-boardgame-description

virre commented 4 years ago

As I wrote on the above bugreport, it is possible that BGG have added BOMS to the XML response and if I see correctly you use JAVA that can't handle UTF-8 strings with BOM. (JAVA is not a language I am knowledgeable about as I have hardly touched it after 2000, but google seems to sugest this)

Kaligula0 commented 4 years ago

API v1 returns properly encoded characters. API v2 has bugs.

Kaligula0 commented 1 year ago

Can we move to API v1 then? (with getting the description)