search

ccomeaux / boardgamegeek4android

BoardGameGeek application for Android (unofficial)
GNU General Public License v3.0
228 stars 47 forks source link

Dark mode for Android 10+ #158

Open lehenry opened 3 years ago

lehenry commented 3 years ago

Use background color in splash screen, Add force dark allowed for Android API 29+ (follows the user theme) Night color scheme for 'light blue' to fix row dividers Screenshot_1607779471 Screenshot_1607779734

Kaligula0 commented 3 years ago

Great idea! 👌 🤩 Is it difficult to make it Android 9+? 🤔

lehenry commented 3 years ago

@Kaligula0 yes, it would be a bit more complicated, with Android 10, there is no need for a specific setting, there is a system flag for the dark mode, and I didn't wrote a full theme, the dark mode convert (almost) all colors by itself. I took the lazy path 😉

erikhuizinga commented 3 years ago

I'd stick with dark mode for the more recent Android versions only, as usage of older versions than Android 10 should be limited and declining. Furthermore, it keeps this PR simple.

Kaligula0 commented 3 years ago

@erikhuizinga I know, I know… I just love dark mode but my phone development finished on Android 9 🤷 Nevertheless I am definitively for that Pull request!

erikhuizinga commented 3 years ago

It can always be be developed for Android <= 9 (by you? 😉) after this PR is accepted.

Kaligula0 commented 8 months ago

Is this PR still alive?